[14.0] [IMP] cetmix_tower_server: managers can remove flightplan lines #98
+280
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot rebase |
|
Congratulations, PR rebased to 14.0-dev. |
CetmixGitDrone
force-pushed
the
14.0-t3510-managers-can-remove-flightplan-lines
branch
from
6816d5f
to
4102885
Compare
Aldeigja
force-pushed
the
14.0-t3510-managers-can-remove-flightplan-lines
branch
2 times, most recently
from
26fa3f1
to
7e89f1f
Compare
Before this commit ------------------ Members of the group_manager cannot delete the plan lines they have created After this commit ------------------ Members of the group_manager can delete the plan lines they have created
Before this commit
------------------
Members of the group_manager cannot delete the plan line actions they have created
After this commit
------------------
Members of the group_manager can delete the plan lines actions they have created
Before this commit: memnbers of group_user and group_manager have no access to variable values related to plan line actions After this commit: members of group user can read variable values related to plan line actions members of group manager can - read variable values related to plan line actions - delete variable values related to plan line actions they have created
Aldeigja
force-pushed
the
14.0-t3510-managers-can-remove-flightplan-lines
branch
from
7e89f1f
to
062210f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managers can only add flight plan lines to the flight plan, and can't remove them so they can't fix their own mistakes
TODO
Allow manages to modify and delete flight plan lines of the plans they have created.